Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stop): change csgoserver stop mode #3171

Merged
merged 4 commits into from
Jan 16, 2021
Merged

fix(stop): change csgoserver stop mode #3171

merged 4 commits into from
Jan 16, 2021

Conversation

h3o66
Copy link
Member

@h3o66 h3o66 commented Jan 9, 2021 •
edited by dgibbs64
Loading

Description

Changes stop mode to 9 (GoldSrc) to take in to account -autoupdate in the arguments.

Fixes #2992

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@h3o66 h3o66 requested a review from dgibbs64 January 9, 2021 16:15
@h3o66 h3o66 linked an issue Jan 9, 2021 that may be closed by this pull request
[Feature Request] Exitmode: CTRL+C + quit command #2992
Closed
@h3o66 h3o66 enabled auto-merge (squash) January 12, 2021 00:04
@dgibbs64 dgibbs64 changed the title refactor(stop): add stop mode ctrl+c and quit fix(stop): add stop mode ctrl+c and quit Jan 12, 2021
@dgibbs64
Copy link
Member

subject should be either feat or fix. Refactor is not supported (but wish it was).

dgibbs64
dgibbs64 requested changes Jan 12, 2021
View reviewed changes
Copy link
Member

@dgibbs64 dgibbs64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CS:GO in this instance is acting like many GolgSrc servers in that quit triggers a restart of the server

The solution is to change CS:GO to use 9: GoldSrc stop option as it sends quit then closes 3 seconds after the quit.

@TheByKotik
Copy link

CS:GO in this instance is acting like many GolgSrc servers in that quit triggers a restart of the server

The solution is to change CS:GO to use 9: GoldSrc stop option as it sends quit then closes 3 seconds after the quit.

I suppose correct server shutdown better than restart and killing process.

@dgibbs64
Copy link
Member

@TheByKotik The correct shutdown is quit then ctrl+c. ctrl+c alone is forcing close

@dgibbs64 dgibbs64 changed the title fix(stop): add stop mode ctrl+c and quit fix(stop): change csgoserver stop mode Jan 16, 2021
@dgibbs64 dgibbs64 added this to the v21.1.0 milestone Jan 16, 2021
@dgibbs64 dgibbs64 self-requested a review January 16, 2021 15:46
@dgibbs64 dgibbs64 merged commit f449154 into GameServerManagers:develop Jan 16, 2021
@TheByKotik
Copy link

@TheByKotik The correct shutdown is quit then ctrl+c. ctrl+c alone is forcing close

image

CTRL + C will be delayed with -autoupdate params.

@h3o66 h3o66 deleted the refactor/2992-exitmode branch January 16, 2021 22:15
dgibbs64 added a commit that referenced this pull request Jan 24, 2021
@h3o66 @dgibbs64
fix(stop): change csgoserver stop mode (#3171)
7bbf581 
Co-authored-by: Daniel Gibbs <[email protected]>
dgibbs64 added a commit that referenced this pull request Jan 25, 2021
@h3o66 @dgibbs64
fix(stop): change csgoserver stop mode (#3171)
785b117 
Co-authored-by: Daniel Gibbs <[email protected]>
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dgibbs64 dgibbs64 dgibbs64 approved these changes

Assignees
No one assigned
Labels
command: stop game: Counter-Strike: Global Offensive type: refactor
Projects
None yet
Milestone
v21.1.0
Development

Successfully merging this pull request may close these issues.

[Feature Request] Exitmode: CTRL+C + quit command
3 participants
@h3o66 @dgibbs64 @TheByKotik